N21-1298 tool context restrictions #4579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns' into N21-1298-tool-context-restrictions
1 task
…ns' into N21-1298-tool-context-restrictions
3 tasks
MarvinOehlerkingCap
requested changes
Nov 28, 2023
apps/server/src/modules/tool/common/uc/tool-permission-helper.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/context-external-tool/service/context-external-tool.service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/context-external-tool/service/context-external-tool.service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/tool-launch/controller/api-test/tool-launch.controller.api.spec.ts
Show resolved
Hide resolved
apps/server/src/modules/tool/external-tool/service/external-tool-configuration.service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/external-tool/controller/api-test/tool-configuration.api.spec.ts
Show resolved
Hide resolved
apps/server/src/modules/tool/external-tool/controller/api-test/tool-configuration.api.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/context-external-tool/uc/context-external-tool.uc.spec.ts
Show resolved
Hide resolved
...server/src/modules/tool/context-external-tool/controller/api-test/tool-reference.api.spec.ts
Show resolved
Hide resolved
.../server/src/modules/tool/context-external-tool/service/context-external-tool.service.spec.ts
Outdated
Show resolved
Hide resolved
1 task
# Conflicts: # apps/server/src/modules/tool/context-external-tool/service/context-external-tool.service.spec.ts # apps/server/src/modules/tool/context-external-tool/service/context-external-tool.service.ts # apps/server/src/modules/tool/external-tool/uc/external-tool-configuration.uc.spec.ts # apps/server/src/modules/tool/external-tool/uc/external-tool-configuration.uc.ts
…ns' into N21-1298-tool-context-restrictions
MarvinOehlerkingCap
requested changes
Nov 30, 2023
apps/server/src/modules/tool/external-tool/service/external-tool-configuration.service.ts
Outdated
Show resolved
Hide resolved
...src/modules/tool/context-external-tool/service/restricted-context-mismatch-loggabble.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/context-external-tool/service/context-external-tool.service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/context-external-tool/service/context-external-tool.service.ts
Outdated
Show resolved
Hide resolved
.../server/src/modules/tool/context-external-tool/service/context-external-tool.service.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/context-external-tool/controller/api-test/tool-context.api.spec.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # apps/server/src/modules/tool/external-tool/controller/api-test/tool-configuration.api.spec.ts # apps/server/src/modules/tool/external-tool/uc/external-tool-configuration.uc.spec.ts # apps/server/src/modules/tool/external-tool/uc/external-tool-configuration.uc.ts # apps/server/src/modules/tool/tool-launch/controller/api-test/tool-launch.controller.api.spec.ts
…ns' into N21-1298-tool-context-restrictions
MarvinOehlerkingCap
approved these changes
Dec 1, 2023
apps/server/src/modules/tool/external-tool/uc/external-tool-configuration.uc.spec.ts
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
bergatco
pushed a commit
that referenced
this pull request
Dec 6, 2023
* get tools/context-types * extend external tool data model by restrictToContexts * available tools filter for contexts * create context external tool validation for restricted contexts * add seed data --------- Co-authored-by: Malte Berg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the new attribute 'restrictToContexts' of an external tool the superhero can restrict the tool usage to contexts (atm only 'course' and 'board-element').
In this PR the SHD endpoints are adjusted to the new attribute, a new context-types endpont is created and the a filter / validation logic is added to the available tools for context (the dropdown to add tools) and the creation of context tools.
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/N21-1298
hpi-schul-cloud/superhero-dashboard#235
hpi-schul-cloud/nuxt-client#2929
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.